The test_find_not_should_ignore_path is now in heisentests #10989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems that the test_find_not_should_ignore_path test has some dependency on side-effects from other tests. See apache#10988 - we are moving this test to heisentests until we solve the issue.
potiuk
force-pushed
the
move-test_find_not_should_ignore_path-to-heisentests
branch
from
e12ab72
to
f62d7f9
Compare
|
Give me an hour or so, let me see if I can fix it |
Cool. I looked at this one and the test does not seem complex, but I think it is a weird side effect that might be difficult to diagnose quickly - like some tests removing .airflowignore or simply sometimes leaving new files in the dag folder. So I was afraid it might be a difficult one to find and - especially - difficult one to prove that it is fixed :). |
kaxil
approved these changes
Sep 17, 2020
potiuk
deleted the
move-test_find_not_should_ignore_path-to-heisentests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that the test_find_not_should_ignore_path test has some
dependency on side-effects from other tests.
See #10988 - we are moving this test to heisentests until we
solve the issue.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.